| 1 |
On Sat, 10 Oct 2015 10:09:11 +0200 |
| 2 |
Michał Górny <mgorny@g.o> wrote: |
| 3 |
|
| 4 |
> Hello, developers. |
| 5 |
> |
| 6 |
> I have the pleasure to announce that we have formed a new Reviewers |
| 7 |
> team [1] for Gentoo. The team is going to assemble developers willing |
| 8 |
> to perform ebuild reviews and help contributors improve their ebuild |
| 9 |
> skills. |
| 10 |
> |
| 11 |
> The main goal of the team is to handle GitHub pull requests. We are |
| 12 |
> going to review incoming PRs, communicate with maintainers and merge |
| 13 |
> them as appropriate. In particular, we're going to help willing |
| 14 |
> contributors get high-quality, PGP-signed commits into Gentoo, |
| 15 |
> therefore helping them prepare to become Gentoo developers. |
| 16 |
|
| 17 |
This is cool |
| 18 |
|
| 19 |
> The side goal is to review current Gentoo commits for major QA |
| 20 |
> violations and other issues, aiming at improving the quality of |
| 21 |
> ebuilds in Gentoo and helping other developers using bash, ebuilds |
| 22 |
> and git effectively. |
| 23 |
|
| 24 |
This is completely unrelated: since we've had gentoo-commits ml, |
| 25 |
every one has been able to do commit reviews easily, and most devs have |
| 26 |
done so. Self-proclamed reviewers project certainly does not have the |
| 27 |
monopoly of best practices nor perfect knowledge. I hope they do keep |
| 28 |
the monopoly of being harassing though :) |
| 29 |
|
| 30 |
Also, you should probably focus on what's really important: reviews |
| 31 |
like "this is weird, care to explain?" or stylistic nitpicks are just a |
| 32 |
waste of every one time, meaning more important stuff does not get done. |
Archives