1 |
On Thursday 20 September 2007, Chris Gianelloni wrote: |
2 |
> On Thu, 2007-09-20 at 12:34 -0400, Mike Frysinger wrote: |
3 |
> > > > what catalyst should do is just before cleaning up the stage3 root |
4 |
> > > > and packing it up is run `rsync -a /etc/skel/ /root/` |
5 |
> > > |
6 |
> > > It definitely should not. One of my primary motivations with catalyst |
7 |
> > > is to ensure that the users get *exactly* what would be provided by the |
8 |
> > > profiles/packages. We don't add extra files into the stages and likely |
9 |
> > > never will. Doing something like this in catalyst would create an |
10 |
> > > inconsistency between doing a stage3 install and any previous stage |
11 |
> > > installs. Yes, we don't support stage1 anymore, but we still support |
12 |
> > > stage1 users once their systems are up and running. Having them |
13 |
> > > inconsistent only causes one more area where we have to do extra |
14 |
> > > troubleshooting to determine the cause. |
15 |
> > |
16 |
> > not really ... someone installing by hand and someone taking a default |
17 |
> > setup are different things. we know that someone taking a stage3 has |
18 |
> > never configured anything before and so we can safely put defaults into |
19 |
> > /root/. we have no idea what people have done when they run emerge |
20 |
> > themselves. that is why only putting this into catalyst makes sense. |
21 |
> |
22 |
> I'll respectfully disagree and say again that I won't add anything like |
23 |
> this to catalyst for the reasons mentioned above. I see no reason why |
24 |
> we cannot provide sensible defaults in stages lower than three, |
25 |
> especially since I want to see everything in ebuild code. |
26 |
> |
27 |
> Also, my plan for this would be add the copying of the .bash* files |
28 |
> from /etc/skel if and only if USE=build *and* the files do not already |
29 |
> exist, done during pkg_preinst/pkg_postinst somewhere. This will pull |
30 |
> it into the stage1 tarball, making it available to everyone on all |
31 |
> further stages, it keeps it from being done every time someone emerges |
32 |
> bash, it doesn't stomp on existing files, and it doesn't show up in VDB |
33 |
> linked to the bash package. Is this acceptable? |
34 |
|
35 |
no, bash is not a special case |
36 |
|
37 |
why not add an `emerge --config baselayout` to the end of stage3 and i'll do |
38 |
the /root/ default setup in the baselayout ebuild |
39 |
|
40 |
> > > Well, it depends on whether we're interested in getting all of |
41 |
> > > /etc/skel or just the .bash* files. About the only thing I would see |
42 |
> > > useful as "defaults" is the .bash* stuff and a .ssh directory. I do |
43 |
> > > agree that everything else should be left up to the user. If we |
44 |
> > > decided what to include and limited it, it shouldn't be a problem to do |
45 |
> > > it via USE=build at all. |
46 |
> > |
47 |
> > anything that is part of the system /etc/skel/ makes sense (iow, anything |
48 |
> > that is in /etc/skel/ at the end of stage3). the files from bash and the |
49 |
> > .ssh dir are the only things that go into /etc/skel/ right now for the |
50 |
> > default system. |
51 |
> |
52 |
> OK. So we now know that only bash/openssh would be really important |
53 |
> here, and the .ssh directory really isn't much of a show-stopper, since |
54 |
> it isn't populated. I mention this only because we don't install |
55 |
> openssh until stage3, so there's no special USE flags in use at that |
56 |
> time. If we limited it to bash (and tcsh, etc. for non-Linux) using |
57 |
> USE=build, it would satisfy this request, one which I personally would |
58 |
> like to see done, and still not have to change a single line of code in |
59 |
> catalyst, which also respects my wishes. It doesn't stomp on user's |
60 |
> files. All in all, it seems like a safe enough solution to me. |
61 |
|
62 |
no ... the fact that *today* we have just bash/openssh and *today* openssh is |
63 |
installing an empty dir (not exactly empty, the permissions are set much |
64 |
stricter than default `mkdir`) is irrelevant ... i want to fix this once and |
65 |
only once and not see another request about XYZ package installs FOO and now |
66 |
we decided we also want special code to handle FOO |
67 |
-mike |