Gentoo Archives: gentoo-dev

From: Michael Orlitzky <michael@××××××××.com>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: RFC: CONFIG_CHECK_FATAL, making CONFIG_CHECKS fatal by default
Date: Thu, 24 Jan 2013 18:55:53
Message-Id: 510183B2.8020603@orlitzky.com
In Reply to: Re: [gentoo-dev] Re: RFC: CONFIG_CHECK_FATAL, making CONFIG_CHECKS fatal by default by Rich Freeman
1 On 01/24/13 13:25, Rich Freeman wrote:
2 > On Thu, Jan 24, 2013 at 1:18 PM, Ian Stakenvicius <axs@g.o> wrote:
3 >> a fatal die in pkg_pretend could be circumvented by an environment
4 >> variable such as ${PN}_I_KNOW_WHAT_IM_DOING being set. Just a thought.
5 >
6 > If we're going to do this I'd definitely have the ${PN} bit as you
7 > suggested. Otherwise everybody will just set it in make.conf and the
8 > feature will be pointless. Then we'll yell at users because they
9 > disabled the feature that normally just tends to break half their
10 > builds but this time by some miracle would have actually prevented a
11 > problem.
12
13 Are there really that many ways that this could cause false positives?
14 (Not that I'm against the $PN prefix, just curious).
15
16 I've only seen two legitimate examples: catalyst (whose developers are
17 more than capable of setting a variable) and a supervisor-provided
18 kernel for which you have no information.

Replies