Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: gtk-sharp-module.eclass

[Peter Alfredsen]

On Wednesday 26 November 2008, Donnie Berkholz wrote:
> On 23:52 Tue 25 Nov     , Peter Alfredsen (loki_val) wrote:
> > loki_val    08/11/25 23:52:04
> >
> >   Added:                gtk-sharp-module.eclass
> >   Log:
> >   eclass required for gnome-sharp and gnome-desktop-sharp packages
>
> Did I miss this on gentoo-dev? All eclasses must be sent there for
> review before addition to the tree.

*loki_val bumps his head into the wall.
See, what happened was...
I have been doing nothing else but testing and bumping dotnet packages 
for the last 3 days when not at work, so I kind of forgot that step. 
Fortunately all packages using this eclass are still in package.mask.

Anyway, the eclass is derived from the gtk-sharp-component eclass (which 
is a real bitrot mess that has to support 3 or 4 different naming 
schemes) and is basically a simplification of that.

> > if [[ " ${gtk_sharp_module_list} " == *" ${GTK_SHARP_MODULE} "* ]]
> > ; then my_module_list="${gtk_sharp_module_list}"
> > 	my_tarball="gtk-sharp"
> > elif [[ " ${gnome_sharp_module_list} " == *" ${GTK_SHARP_MODULE} "*
> > ]] ; then
>
> This seems like a really strange strategy for checking whether a
> certain item is in a list.

I disagree.

> > 	# Make selecting components configurable.
> > 	epatch ${WORKDIR}/${MY_P}-configurable.diff
>
> This seems like something you might want optional, depending on some
> variable.

It really isn't. That patch adds AC_ARG_ENABLEs to configure so we can 
split up the gnome-sharp and gnome-desktop-sharp tarballs into smaller 
pieces.

> > 	# Fixes support with pkgconfig-0.17, #92503.
> > 	sed -i -e 's/\<PKG_PATH\>/GTK_SHARP_PKG_PATH/g' \
> > 			-e ':^CFLAGS=:d' \
> > 			${S}/configure.in
>
> It would be nice to quote all instances of $S, $D etc.

CanDo.

> > 	LANG=C emake -j1 || die "emake failed"
>
> Worth a comment about parallel make being broken, with a reference to
> the upstream bug.

This is inherited from the old eclass. Upstream does not care and 
there's only work enough for one make job anyway.

Attached is a diff from the old eclass to the new eclass, generated 
thusly:
diff -wU5 gtk-sharp-component.eclass gtk-sharp-module.eclass



-- 
/PA