Gentoo Archives: gentoo-dev

From: Dan Armak <danarmak@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Proposed change to base.eclass: patch || die
Date: Fri, 29 Jul 2005 14:05:44
Message-Id: 200507291705.02687.danarmak@gentoo.org
In Reply to: Re: [gentoo-dev] Proposed change to base.eclass: patch || die by "Diego 'Flameeyes' Pettenò"
1 On Friday 29 July 2005 16:57, Diego 'Flameeyes' Pettenò wrote:
2 > On Friday 29 July 2005 15:56, Dan Armak wrote:
3 > > base.eclass (which inherited by many other eclasses) has an src_unpack
4 > > supporting patching from patchfiles listed in $PATCHES. However, today,
5 > > if patching fails the process doesn't abort.
6 >
7 > Why can't we just use epatch?
8 We can. It's just that base.eclass existed long before epatch, so it doesn't
9 use it :-)
10
11 Anyway, the effective change would be to die if patching fails (and support
12 patchlevels != 0), so my orig question stands.
13
14 --
15 Dan Armak
16 Gentoo Linux developer (KDE)
17 Public GPG key: http://dev.gentoo.org/~danarmak/danarmak-gpg-public.key
18 Fingerprint: DD70 DBF9 E3D4 6CB9 2FDD 0069 508D 9143 8D5F 8951

Replies

Subject Author
Re: [gentoo-dev] Proposed change to base.eclass: patch || die "Diego 'Flameeyes' Pettenò" <flameeyes@g.o>