Gentoo Archives: gentoo-portage-dev

From: Duncan <1i5t5.duncan@×××.net>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] Re: [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK
Date: Tue, 21 Apr 2015 09:48:37
Message-Id: pan$edae3$8393dbb8$948e43df$d0753b7a@cox.net
In Reply to: Re: [gentoo-portage-dev] [PATCHv3 1/2] MEDIUM: misc-functions: Be more quiet when removing non existing INSTALL_MASK by Zac Medico
1 Zac Medico posted on Mon, 20 Apr 2015 17:37:15 -0700 as excerpted:
2
3 > On 04/20/2015 05:31 PM, Bertrand Jacquin wrote:
4 >> On 21/04/2015 00:39, Zac Medico wrote:
5 >>> These are in the master branch now:
6 >>>
7 >>> https://gitweb.gentoo.org/proj/portage.git/commit/?
8 id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911
9 >>>
10 >>> https://gitweb.gentoo.org/proj/portage.git/commit/?
11 id=e74e2670e3f043608fced9847e54bdbb19f35169
12 >>>
13 >>
14 >> Thanks for that :)
15 >>
16 >>> I modified the test as follows in order to ensure that it still works
17 >>> with shell globs:
18 >>>
19 >>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo
20 >>> "${root}"/${no_inst}) ]] ; then
21 >>
22 >> I do not really understand the use case here, do you have an example ?
23 >>
24 >> Cheers,
25 >>
26 >
27 > Well, I don't use INSTALL_MASK myself, so I don't have a real-world
28 > use-case for you. However, it's clear that the code will expand shell
29 > globs, so I preserved that behavior for compatibility.
30
31 I do, with shell globs, tho I didn't bother checking the above to see if
32 they'd have been affected.
33
34 The two install-masks with globs I use here are:
35
36 *.la
37
38 (Unmasked on libtool itself, since it has a *.la file that other
39 package's .configure scripts test for.)
40
41 /etc/cron.*/
42
43 (I use systemd's timers in place of cron and thus crontablets.)
44
45 --
46 Duncan - List replies preferred. No HTML msgs.
47 "Every nonfree program has a lord, a master --
48 and if you use the program, he is your master." Richard Stallman

Replies