Re: [gentoo-portage-dev] Commit Policy

[Brian Dolbec]

On Mon, 2014-01-13 at 07:43 +0100, Sebastian Luther wrote:
> Am 10.01.2014 11:35, schrieb Brian Dolbec:
> > First off.  Welcome and than you for responding to help with
> > portage.
> >
> > With this many people, we should be able to make good progress
> > without overloading any one person.
> >
> > General rule is to submit all patches to this list for review and
> > approval before committing.
> >
> > Remember to do these always: 1) run pyflakes on your changes to
> > check for faults, misssing imports, variables undefined,...
> >
> > 2) run the testsuite to check for breakage.  It is in the base
> > directory called runtests.sh.  Please try to test it with all
> > minimum supported python versions, but if you have pypy, and some
> > others, then great.
> >
> > 3) any new code that could break things, make a test for it if at
> > all possible.
> >
> >
> > The general exception for patch submittal is for trivial changes
> > such as typo fixes, etc..
> >
> > It will take a bit of time for everyone to acclimate themselves
> > into our new team.  So, I was thinking we give it 2 months, then
> > hold an election for lead in March.  Is that alright with
> > everyone?
> >
> > Thanks
> >
>
> One more useful thing:
>
> Put this in ~/.gitconfig:
> [color]
> 	ui = auto
>
> This way git diff will use colors, including highlighting of trailing
> whitespace.
>
>
>

I use an editor that I have set for both showing whitespace (you see
tabs, spaces) and auto-strips trailing whitespace on save.

nice tip for the git diff.

I like using dev-vcs/gitg for doing commits, viewing different branch
trees, cherry-picking (in color too).  For commits it lets you pick
changes 1 at a time (+ or -) when you've done several changes, but wish
to split them into logical commits.  Handy when you spot things that
need fixing, but don't want to forget to do after your current change
session & commit.

-- 
Brian Dolbec <dolsen@g.o>