| 1 |
On 01/25/2017 07:16 PM, Mike Gilbert wrote: |
| 2 |
> Commit f143e58dd changed the return value of CleanLogs.clean() to a |
| 3 |
> tuple (returncode, messages). |
| 4 |
> |
| 5 |
> X-Gentoo-Bug: 607236 |
| 6 |
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/607236 |
| 7 |
> --- |
| 8 |
> pym/_emerge/post_emerge.py | 6 +++--- |
| 9 |
> 1 file changed, 3 insertions(+), 3 deletions(-) |
| 10 |
> |
| 11 |
> diff --git a/pym/_emerge/post_emerge.py b/pym/_emerge/post_emerge.py |
| 12 |
> index 0cb533cf8..7e6063c52 100644 |
| 13 |
> --- a/pym/_emerge/post_emerge.py |
| 14 |
> +++ b/pym/_emerge/post_emerge.py |
| 15 |
> @@ -29,10 +29,10 @@ def clean_logs(settings): |
| 16 |
> return |
| 17 |
> |
| 18 |
> cleanlogs = CleanLogs() |
| 19 |
> - errors = cleanlogs.clean(settings=settings) |
| 20 |
> - if errors: |
| 21 |
> + returncode, msgs = cleanlogs.clean(settings=settings) |
| 22 |
> + if not returncode: |
| 23 |
> out = portage.output.EOutput() |
| 24 |
> - for msg in errors: |
| 25 |
> + for msg in msgs: |
| 26 |
> out.eerror(msg) |
| 27 |
> |
| 28 |
> def display_news_notification(root_config, myopts): |
| 29 |
> |
| 30 |
|
| 31 |
I like Fixes: tags [1]. Otherwise, looks good. |
| 32 |
|
| 33 |
[1] |
| 34 |
https://kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes |
| 35 |
-- |
| 36 |
Thanks, |
| 37 |
Zac |
Archives