Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] ebuild laziness and binpkg overhead
Date: Wed, 13 Jun 2012 03:04:06
Message-Id: 201206122302.41446.vapier@gentoo.org
i've noticed a growing trend where people put setup of variables into 
pkg_setup that only matter to src_* funcs presumably so they don't have to 
call the respective src_* func from an inherited eclass.  unfortunately this 
adds pointless overhead to binpkgs.  can we please move away from this 
practice ?

i've seen this with a good number of the GNOME packages like:
pkg_setup() {
    G2CONF="${G2CONF}
        --disable-bash-completion
        --disable-hal
        --disable-schemas-compile
        --with-dbus-service-dir=/usr/share/dbus-1/services
        $(use_enable afp)
        $(use_enable archive)
        $(use_enable avahi)
        $(use_enable bluetooth obexftp)
        $(use_enable bluray)
        $(use_enable cdda)
        $(use_enable fuse)
        $(use_enable gdu)
        $(use_enable gphoto2)
        $(use_enable ios afc)
        $(use_enable udev)
        $(use_enable udev gudev)
        $(use_enable http)
        $(use_enable gnome-keyring keyring)
        $(use_enable samba)"
}

ugh
-mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies