1 |
On 10/23/2011 04:27 PM, Rich Freeman wrote: |
2 |
> On Sun, Oct 23, 2011 at 8:39 AM, Samuli Suominen <ssuominen@g.o> wrote: |
3 |
>> On 10/23/2011 03:00 PM, Tomas Chvatal (scarabeus) wrote: |
4 |
>>> scarabeus 11/10/23 12:00:55 |
5 |
>>> |
6 |
>>> Modified: ChangeLog cdparanoia-3.10.2-r3.ebuild |
7 |
>>> Log: |
8 |
>>> Bump to eapi4 and punt static libs. |
9 |
>> |
10 |
>> Time to revert this commit as I don't see anything in the ebuild that |
11 |
>> disables building the static archives at compile phase. |
12 |
>> |
13 |
>> This is same as hiding the problem, not solving it. Not the way we do |
14 |
>> things at sound@. |
15 |
>> |
16 |
>>> + use static-libs || find "${ED}" -name '*.a' -exec rm -f {} + |
17 |
> |
18 |
> Doesn't reverting this seem a bit like shooting yourself in the foot |
19 |
> to remove an ingrown toenail? |
20 |
> |
21 |
> Unless I'm missing something this DOES get rid of the unneeded |
22 |
> archives. Now, sure, you'd save a few milliseconds of CPU if they |
23 |
> weren't built in the first place. However, you're proposing replacing |
24 |
> an ebuild that builds but doesn't install undesired files with one |
25 |
> that builds them AND installs them (since the hypothetical ebuild that |
26 |
> does neither doesn't exist yet). |
27 |
> |
28 |
> Perfection shouldn't hold us back from improvement. By all means open |
29 |
> up a bug asking for the next level of improvement if it really bothers |
30 |
> people. |
31 |
> |
32 |
> Now, if there is some subtle issue that causes issues during build if |
33 |
> the files are there and only removed at the last minute then clearly |
34 |
> that is a bigger problem. |
35 |
|
36 |
If you only wanted to remove these files, you are free to use |
37 |
INSTALL_MASK locally instead of downgrading the quality of tree. |
38 |
|
39 |
Do you have any idea how much time me, and aballier spent to make |
40 |
cdparanoia's build system as clean as it is now? And then to coordinate |
41 |
them with upstream xiph.org? |
42 |
Then I see this... Not acceptable by any standards. |