Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-drivers/nvidia-drivers: nvidia-drivers-313.18.ebuild ChangeLog

[Alec Warner]

On Sat, Mar 2, 2013 at 11:01 PM, Samuli Suominen <ssuominen@g.o> wrote:
> On 02/03/13 18:02, Doug Goldstein (cardoe) wrote:
>>
>> cardoe      13/03/02 16:02:57
>>
>>    Modified:             nvidia-drivers-313.18.ebuild ChangeLog
>>    Log:
>>    Revert non-maintainer changes per bug #447566.
>>
>>    (Portage version: 2.1.11.52/cvs/Linux x86_64, signed Manifest commit
>> with key D7DFA8D318FA9AEF!)
>>
>> Revision  Changes    Path
>> 1.6
>> x11-drivers/nvidia-drivers/nvidia-drivers-313.18.ebuild
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-drivers/nvidia-drivers/nvidia-drivers-313.18.ebuild?rev=1.6&view=markup
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-drivers/nvidia-drivers/nvidia-drivers-313.18.ebuild?rev=1.6&content-type=text/plain
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-drivers/nvidia-drivers/nvidia-drivers-313.18.ebuild?r1=1.5&r2=1.6
>>
>> Index: nvidia-drivers-313.18.ebuild
>> ===================================================================
>> RCS file:
>> /var/cvsroot/gentoo-x86/x11-drivers/nvidia-drivers/nvidia-drivers-313.18.ebuild,v
>> retrieving revision 1.5
>> retrieving revision 1.6
>> diff -u -r1.5 -r1.6
>> --- nvidia-drivers-313.18.ebuild        2 Mar 2013 11:30:39 -0000
>> 1.5
>> +++ nvidia-drivers-313.18.ebuild        2 Mar 2013 16:02:57 -0000
>> 1.6
>> @@ -1,6 +1,6 @@
>>   # Copyright 1999-2013 Gentoo Foundation
>>   # Distributed under the terms of the GNU General Public License v2
>> -# $Header:
>> /var/cvsroot/gentoo-x86/x11-drivers/nvidia-drivers/nvidia-drivers-313.18.ebuild,v
>> 1.5 2013/03/02 11:30:39 ssuominen Exp $
>> +# $Header:
>> /var/cvsroot/gentoo-x86/x11-drivers/nvidia-drivers/nvidia-drivers-313.18.ebuild,v
>> 1.6 2013/03/02 16:02:57 cardoe Exp $
>>
>>   EAPI=5
>>
>> @@ -156,9 +156,6 @@
>>             epatch "${FILESDIR}"/nvidia-drivers-pax-usercopy.patch
>>         fi
>>
>> -       epatch "${FILESDIR}"/${PN}-313.18-builddir-config.patch
>> -       epatch "${FILESDIR}"/${PN}-313.18-linux-3.{7,8}+.patch #447566
>> -
>>         # Allow user patches so they can support RC kernels and whatever
>> else
>>         epatch_user
>>   }
>>
>>
>>
>> 1.427                x11-drivers/nvidia-drivers/ChangeLog
>>
>> file :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-drivers/nvidia-drivers/ChangeLog?rev=1.427&view=markup
>> plain:
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-drivers/nvidia-drivers/ChangeLog?rev=1.427&content-type=text/plain
>> diff :
>> http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-drivers/nvidia-drivers/ChangeLog?r1=1.426&r2=1.427
>>
>> Index: ChangeLog
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/x11-drivers/nvidia-drivers/ChangeLog,v
>> retrieving revision 1.426
>> retrieving revision 1.427
>> diff -u -r1.426 -r1.427
>> --- ChangeLog   2 Mar 2013 11:30:39 -0000       1.426
>> +++ ChangeLog   2 Mar 2013 16:02:57 -0000       1.427
>> @@ -1,6 +1,12 @@
>>   # ChangeLog for x11-drivers/nvidia-drivers
>>   # Copyright 1999-2013 Gentoo Foundation; Distributed under the GPL v2
>> -# $Header: /var/cvsroot/gentoo-x86/x11-drivers/nvidia-drivers/ChangeLog,v
>> 1.426 2013/03/02 11:30:39 ssuominen Exp $
>> +# $Header: /var/cvsroot/gentoo-x86/x11-drivers/nvidia-drivers/ChangeLog,v
>> 1.427 2013/03/02 16:02:57 cardoe Exp $
>> +
>> +  02 Mar 2013; Doug Goldstein <cardoe@g.o>
>> +  -files/nvidia-drivers-313.18-builddir-config.patch,
>> +  -files/nvidia-drivers-313.18-linux-3.7+.patch,
>> +  -files/nvidia-drivers-313.18-linux-3.8+.patch,
>> nvidia-drivers-313.18.ebuild:
>> +  Revert non-maintainer changes per bug #447566.
>>
>>     02 Mar 2013; Samuli Suominen <ssuominen@g.o>
>>     nvidia-drivers-313.18.ebuild,
>> +files/nvidia-drivers-313.18-linux-3.8+.patch:
>
>
> There was no reason for this commit and for reverting you have to justify
> your commit in technical terms.
>
> I'll wait for your reply before restoring the patches in the ebuild.

There was a big ole' chat on #gentoo-dev regarding this. My
understanding of the summary is that the nvidia-driver Gentoo team
only supports kernels that nvidia themselves (upstream) support. The
Kernels > 3.4 are not supported by upstream, so they are also not
supported in Gentoo. I believe the ebuild contains instructions on
using user_patches to get these patches. The nvidia maintainers in
Gentoo do not want to be responsible for those patches though; this is
why they are not included (and why your commit was reverted.)

I do not find their stance wholly unreasonable. They offered to point
users at an overlay, if someone was willing to maintain the patches
there (in lieu of user_patches.) The end result is that if users apply
the patches, they will get an unsupported setup. There is a fear as
well, that the patches may damage cards (since the patches are not
supported by the vendor.)

-A

>
> - Samuli
>
>