Gentoo Archives: gentoo-dev

From: Michael 'veremitz' Everitt <gentoo@×××××××.xyz>
To: gentoo-dev@l.g.o, David Seifert <soap@g.o>
Subject: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
Date: Fri, 03 Jan 2020 22:34:27
Message-Id: e232ec5f-2e1d-9c26-a23e-3bbf60c22b7c@veremit.xyz
In Reply to: Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies by David Seifert
1 On 03/01/20 10:36, David Seifert wrote:
2 > On Thu, 2020-01-02 at 21:54 +0000, Michael 'veremitz' Everitt wrote:
3 >> On 02/01/20 21:08, Michał Górny wrote:
4 >>> On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
5 >>>>>>>>> On Thu, 02 Jan 2020, Michał Górny wrote:
6 >>>>> --- a/eclass/ruby-ng.eclass
7 >>>>> +++ b/eclass/ruby-ng.eclass
8 >>>>> @@ -137,7 +137,7 @@ ruby_samelib() {
9 >>>>> local res=
10 >>>>> for _ruby_implementation in $(_ruby_get_all_impls); do
11 >>>>> has -${_ruby_implementation} $@ || \
12 >>>>> - res="${res}ruby_targets_${_ruby_impleme
13 >>>>> ntation}?,"
14 >>>>> + res="${res}ruby_targets_${_ruby_impleme
15 >>>>> ntation}(-)?,"
16 >>>>> done
17 >>>>>
18 >>>>> echo "[${res%,}]"
19 >>>> Hadn't we established that ruby_samelib() is dead code, no longer
20 >>>> used
21 >>>> since 2010?
22 >>>>
23 >>> You did. However, it isn't marked as private API and I'm not the
24 >>> eclass
25 >>> maintainer to take care of removing public API. I have no clue if
26 >>> Ruby
27 >>> project doesn't have some secret overlays using it.
28 >>>
29 >> <sarcasm> You can't use QA super-powerz ?! BDFL + sub-BDFL ?!
30 >> </sarcasm>*
31 >>
32 >> * Thought the tags probably worth making explicit
33 >>
34 > Can you please stop polluting the -dev mailing list with this senseless
35 > chatter?
36 >
37 >
38 Perhaps I should remind you that this is a public mailing list (or hasn't
39 successfully been censored Yet) and not a private communication channel for
40 developers (see -core for this). But I don't need to tell you this....

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies