1 |
On Mon, 2005-09-12 at 13:55 +0200, Carsten Lohrke wrote: |
2 |
> On Monday 12 September 2005 02:25, Ciaran McCreesh wrote: |
3 |
> > If you're not up for having your code reviewed, don't contribute to an |
4 |
> > open source project. No-one expects you to produce perfect code |
5 |
> > straight off (at least, we don't until we give you commit access). We |
6 |
> > *do* expect you to be prepared to respond to constructive criticism and |
7 |
> > improve your code. |
8 |
> |
9 |
> Personally I think you're just going a bit wild by closing the bug reports as |
10 |
> wont fix and expecting users to fix them. That's part of developers job, if |
11 |
> someone takes into account adding an ebuild to the official tree, isn't it?! |
12 |
> While I can understand your motivation, I'd like to know if your doing is |
13 |
> backed up by at least an informal decision (didn't follow the threads which |
14 |
> resulted in the maintainer* aliases, etc.), because we have enough whining |
15 |
> guys, who don't understand that our ressources are limited. Caring for the |
16 |
> quality of stuff, that is not part of the official tree is only bad PR, but |
17 |
> not a win for us, imho. |
18 |
|
19 |
We generally handle this in games not by marking it WONTFIX (except |
20 |
rarely) but instead by simply leaving it open, and commenting to the |
21 |
users what they need to fix before it would be included. We aren't 100% |
22 |
stringent on what we require users to fix, and many times we'll fix it |
23 |
ourselves if it isn't that much and simply note it in the bug for the |
24 |
user to see. This tends to lead to users providing better ebuilds in |
25 |
the future, and also lessens user frustration. Many users seem to think |
26 |
that a WONTFIX is non-negotiable. I tend to agree with them, for the |
27 |
most part. Rather than WONTFIX them, simply tell them that they won't |
28 |
be included as-is. WONTFIX gives the user the impression that we are |
29 |
not interested in their work or the package, when this is not the case. |
30 |
|
31 |
-- |
32 |
Chris Gianelloni |
33 |
Release Engineering - Strategic Lead/QA Manager |
34 |
Games - Developer |
35 |
Gentoo Linux |